Skip to content

Conversation

PrettyWood
Copy link
Collaborator

No description provided.

@PrettyWood PrettyWood marked this pull request as ready for review August 5, 2022 00:01
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #222 (0870c37) into main (fdf42b8) will increase coverage by 0.01%.
The diff coverage is 95.34%.

@@            Coverage Diff             @@
##             main     #222      +/-   ##
==========================================
+ Coverage   98.66%   98.68%   +0.01%     
==========================================
  Files          48       48              
  Lines        5031     5030       -1     
  Branches       35       35              
==========================================
  Hits         4964     4964              
+ Misses         67       66       -1     
Impacted Files Coverage Δ
src/input/input_python.rs 98.67% <ø> (ø)
src/input/mod.rs 100.00% <ø> (ø)
src/validators/tuple.rs 97.61% <92.85%> (+0.76%) ⬆️
src/input/return_enums.rs 99.34% <93.33%> (ø)
src/input/input_abstract.rs 100.00% <100.00%> (ø)
src/input/input_json.rs 97.51% <100.00%> (ø)
src/validators/frozenset.rs 100.00% <100.00%> (ø)
src/validators/list.rs 100.00% <100.00%> (ø)
src/validators/set.rs 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdf42b8...0870c37. Read the comment docs.

@PrettyWood PrettyWood changed the title rename GenericListLike into GenericCollection + improve tuple validation rename GenericListLike into GenericCollection + improve coverage Aug 5, 2022
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

@samuelcolvin
Copy link
Member

Good idea on the name, but better than before.

@PrettyWood
Copy link
Collaborator Author

Thanks for the review. Done 👍

@samuelcolvin samuelcolvin merged commit 4774adf into pydantic:main Aug 11, 2022
@samuelcolvin
Copy link
Member

thanks so much.

@PrettyWood PrettyWood deleted the fix-tuple branch August 11, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants