Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix type hint for SerializationInfo.round_trip #1576

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fix type hint for SerializationInfo.round_trip #1576

merged 1 commit into from
Dec 9, 2024

Conversation

davidhewitt
Copy link
Contributor

Change Summary

Corrects type hint of round_trip as suggested by @viccie30

Related issue number

Fix #1542

Checklist

  • Unit tests for the changes exist
  • Documentation reflects the changes where applicable
  • Pydantic tests pass with this pydantic-core (except for expected changes)
  • My PR is ready to review, please add a comment including the phrase "please review" to assign reviewers

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #1576 will not alter performance

Comparing dh/round-trip-hint (91e003c) with main (7f13140)

Summary

✅ 155 untouched benchmarks

@davidhewitt davidhewitt merged commit 6a455fb into main Dec 9, 2024
29 checks passed
@davidhewitt davidhewitt deleted the dh/round-trip-hint branch December 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Viicos Viicos Viicos approved these changes

@sydney-runkle sydney-runkle Awaiting requested review from sydney-runkle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing property decorator on SerializationInfo.round_trip
2 participants
@davidhewitt @Viicos