Skip to content

Conversation

samuelcolvin
Copy link
Member

and store undefined on the relevant validators.

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Merging #1157 (685b207) into main (8030c5a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1157      +/-   ##
==========================================
- Coverage   89.94%   89.94%   -0.01%     
==========================================
  Files         106      106              
  Lines       16438    16437       -1     
  Branches       36       36              
==========================================
- Hits        14785    14784       -1     
  Misses       1646     1646              
  Partials        7        7              
Files Coverage Δ
src/argument_markers.rs 86.44% <ø> (-0.66%) ⬇️
src/validators/model.rs 97.84% <100.00%> (+<0.01%) ⬆️
src/validators/with_default.rs 99.09% <100.00%> (+<0.01%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8030c5a...685b207. Read the comment docs.

Copy link

codspeed-hq bot commented Jan 14, 2024

CodSpeed Performance Report

Merging #1157 will not alter performance

Comparing simplify-undefined (685b207) with main (8030c5a)

Summary

✅ 142 untouched benchmarks

@samuelcolvin samuelcolvin merged commit fa65fcd into main Jan 15, 2024
@samuelcolvin samuelcolvin deleted the simplify-undefined branch January 15, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants