Fix weather agent example with UI #1851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… didnt notice since gemini which he used doesnt set that. There was also a bug in the call_args creation, json.dumps is supposed to be called when args_json attribute doesnt exist
vp777
force-pushed
the
fixed_weather_example_June2025
branch
from
2523c61 to
ce1103f
Compare
DouweM
reviewed
May 28, 2025
DouweM
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs, the first was introduced in the last commit. It set the tool call id to a dictionary instead of a string. He didnt notice since he used gemini which doesnt make use of that field.
The 2nd bug was older, it still remained undetected since LLMs (i guess until recently) set the args_json in the call args. Now at least openai doesnt set that field which causes the code to execute the code path with the bug that attempts to use that field
Tested with gpt4o on 28/05/2025