opentelemetry: add span event for instructions
#1529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Kludex
commented
Apr 17, 2025
•
Kludex
commented
- Closes Instruction missing from the message history in logfire #1528
Docs Preview
|
Kludex
commented
Apr 17, 2025
tests/models/test_instrumented.py
Outdated
| InstrumentedModel.event_to_dict(e) for e in InstrumentedModel.messages_to_otel_events(messages) | ||
| ] == snapshot( | ||
| [ | ||
| {'content': 'system_prompt', 'role': 'system', 'event.name': 'gen_ai.system.message'}, |
There was a problem hiding this comment.
It doesn't have the message_index, is that okay?
alexmojaki
requested changes
Apr 17, 2025
| @@ -275,6 +277,10 @@ def messages_to_otel_events(messages: list[ModelMessage]) -> list[Event]: | |||
| **(event.attributes or {}), | |||
| } | |||
| events.extend(message_events) | |||
| if last_model_request and last_model_request.instructions: | |||
| events.insert( | |||
| 0, Event('gen_ai.system.message', body={'content': last_model_request.instructions, 'role': 'system'}) | |||
There was a problem hiding this comment.
Maybe setting the role to instructions would be clearer, but make sure it looks OK in the ui
There was a problem hiding this comment.
It does look OK in the UI.
tests/models/test_instrumented.py
Outdated
| InstrumentedModel.event_to_dict(e) for e in InstrumentedModel.messages_to_otel_events(messages) | ||
| ] == snapshot( | ||
| [ | ||
| {'content': 'system_prompt', 'role': 'system', 'event.name': 'gen_ai.system.message'}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.