Update min openai version #1479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docs Preview
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1478.
Note — as far as I can tell, you can use the new models today by just manually specifying their names. This PR just adds them to the list of "KnownModelName"s; because we sync that list in our tests with the value provided by the OpenAI SDK, we'd need to rework that test to explicitly add the models to the list without updating the openai sdk.
I don't see any reason not to bump the min version of openai SDK, so I'm doing that in this PR, but anyone that wants to use these models today should be aware that you do not need to wait for a new release of pydantic-ai to start using 'gpt-4.1' etc..