Skip to content

Make user_prompt optional #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Make user_prompt optional #1406

merged 2 commits into from
Apr 9, 2025
+104 −14

Conversation

Kludex
Copy link
Member

@Kludex Kludex commented Apr 8, 2025 •
edited
Loading

I only have one question... Do we add the ModelRequest with parts being empty if user_prompt is None, or we don't add the ModelRequest? This PR adds the ModelRequest with empty parts.

@Kludex Kludex requested a review from dmontagu April 8, 2025 08:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025 •
edited
Loading

Docs Preview

commit: eae37a6
Preview URL: https://aea3febb-pydantic-ai-previews.pydantic.workers.dev

@Kludex Kludex force-pushed the allow-none-as-input branch from eae37a6 to 61ab573 Compare April 9, 2025 08:25
@Kludex Kludex enabled auto-merge (squash) April 9, 2025 08:26
@Kludex Kludex merged commit 1a60d8f into main Apr 9, 2025
13 checks passed
@Kludex Kludex deleted the allow-none-as-input branch April 9, 2025 08:31
@lfloeer lfloeer mentioned this pull request Apr 9, 2025
Merged
@Kludex Kludex mentioned this pull request Apr 9, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmontagu dmontagu dmontagu approved these changes

Assignees

@dmontagu dmontagu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run agent only on message list instead of user prompt string?
2 participants
@Kludex @dmontagu