Skip to content

Drop exclusiveMaximum/exclusiveMinimum from Gemini #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

Drop exclusiveMaximum/exclusiveMinimum from Gemini #1341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46f0164
Drop `exclusiveMaximum`/`exclusiveMinimum` from Gemini
Kludex Apr 2, 2025
0945fed
Improve the test
Kludex Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions pydantic_ai_slim/pydantic_ai/models/gemini.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,8 @@ def simplify(self) -> dict[str, Any]:
def _simplify(self, schema: dict[str, Any], refs_stack: tuple[str, ...]) -> None:
schema.pop('title', None)
schema.pop('default', None)
schema.pop('exclusiveMaximum', None)
schema.pop('exclusiveMinimum', None)
if ref := schema.pop('$ref', None):
# noinspection PyTypeChecker
key = re.sub(r'^#/\$defs/', '', ref)
Expand Down
326 changes: 326 additions & 0 deletions tests/models/cassettes/test_gemini/test_gemini_drop_exclusive_maximum.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,326 @@
interactions:
- request:
headers:
accept:
- '*/*'
accept-encoding:
- gzip, deflate
connection:
- keep-alive
content-length:
- '277'
content-type:
- application/json
host:
- generativelanguage.googleapis.com
method: POST
parsed_body:
contents:
- parts:
- text: I want to know my chinese zodiac. I am 20 years old.
role: user
tools:
function_declarations:
- description: ''
name: get_chinese_zodiac
parameters:
properties:
age:
type: integer
required:
- age
type: object
uri: https://generativelanguage.googleapis.com/v1beta/models/gemini-2.0-flash:generateContent
response:
headers:
alt-svc:
- h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
content-length:
- '734'
content-type:
- application/json; charset=UTF-8
server-timing:
- gfet4t7; dur=477
transfer-encoding:
- chunked
vary:
- Origin
- X-Origin
- Referer
parsed_body:
candidates:
- avgLogprobs: 3.357185050845146e-06
content:
parts:
- functionCall:
args:
age: 20
name: get_chinese_zodiac
role: model
finishReason: STOP
modelVersion: gemini-2.0-flash
usageMetadata:
candidatesTokenCount: 7
candidatesTokensDetails:
- modality: TEXT
tokenCount: 7
promptTokenCount: 24
promptTokensDetails:
- modality: TEXT
tokenCount: 24
totalTokenCount: 31
status:
code: 200
message: OK
- request:
headers:
accept:
- '*/*'
accept-encoding:
- gzip, deflate
connection:
- keep-alive
content-length:
- '483'
content-type:
- application/json
host:
- generativelanguage.googleapis.com
method: POST
parsed_body:
contents:
- parts:
- text: I want to know my chinese zodiac. I am 20 years old.
role: user
- parts:
- functionCall:
args:
age: 20
name: get_chinese_zodiac
role: model
- parts:
- functionResponse:
name: get_chinese_zodiac
response:
return_value: Dragon
role: user
tools:
function_declarations:
- description: ''
name: get_chinese_zodiac
parameters:
properties:
age:
type: integer
required:
- age
type: object
uri: https://generativelanguage.googleapis.com/v1beta/models/gemini-2.0-flash:generateContent
response:
headers:
alt-svc:
- h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
content-length:
- '636'
content-type:
- application/json; charset=UTF-8
server-timing:
- gfet4t7; dur=461
transfer-encoding:
- chunked
vary:
- Origin
- X-Origin
- Referer
parsed_body:
candidates:
- avgLogprobs: -2.039197300161634e-06
content:
parts:
- text: |
Your Chinese zodiac is Dragon.
role: model
finishReason: STOP
modelVersion: gemini-2.0-flash
usageMetadata:
candidatesTokenCount: 7
candidatesTokensDetails:
- modality: TEXT
tokenCount: 7
promptTokenCount: 41
promptTokensDetails:
- modality: TEXT
tokenCount: 41
totalTokenCount: 48
status:
code: 200
message: OK
- request:
headers:
accept:
- '*/*'
accept-encoding:
- gzip, deflate
connection:
- keep-alive
content-length:
- '277'
content-type:
- application/json
host:
- generativelanguage.googleapis.com
method: POST
parsed_body:
contents:
- parts:
- text: I want to know my chinese zodiac. I am 17 years old.
role: user
tools:
function_declarations:
- description: ''
name: get_chinese_zodiac
parameters:
properties:
age:
type: integer
required:
- age
type: object
uri: https://generativelanguage.googleapis.com/v1beta/models/gemini-2.0-flash:generateContent
response:
headers:
alt-svc:
- h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
content-length:
- '734'
content-type:
- application/json; charset=UTF-8
server-timing:
- gfet4t7; dur=440
transfer-encoding:
- chunked
vary:
- Origin
- X-Origin
- Referer
parsed_body:
candidates:
- avgLogprobs: 2.7694373524614742e-06
content:
parts:
- functionCall:
args:
age: 17
name: get_chinese_zodiac
role: model
finishReason: STOP
modelVersion: gemini-2.0-flash
usageMetadata:
candidatesTokenCount: 7
candidatesTokensDetails:
- modality: TEXT
tokenCount: 7
promptTokenCount: 24
promptTokensDetails:
- modality: TEXT
tokenCount: 24
totalTokenCount: 31
status:
code: 200
message: OK
- request:
headers:
accept:
- '*/*'
accept-encoding:
- gzip, deflate
connection:
- keep-alive
content-length:
- '685'
content-type:
- application/json
host:
- generativelanguage.googleapis.com
method: POST
parsed_body:
contents:
- parts:
- text: I want to know my chinese zodiac. I am 17 years old.
role: user
- parts:
- functionCall:
args:
age: 17
name: get_chinese_zodiac
role: model
- parts:
- functionResponse:
name: get_chinese_zodiac
response:
call_error: |-
1 validation errors: [
{
"type": "greater_than",
"loc": [
"age"
],
"msg": "Input should be greater than 18",
"input": 17
}
]

Fix the errors and try again.
role: user
tools:
function_declarations:
- description: ''
name: get_chinese_zodiac
parameters:
properties:
age:
type: integer
required:
- age
type: object
uri: https://generativelanguage.googleapis.com/v1beta/models/gemini-2.0-flash:generateContent
response:
headers:
alt-svc:
- h3=":443"; ma=2592000,h3-29=":443"; ma=2592000
content-length:
- '688'
content-type:
- application/json; charset=UTF-8
server-timing:
- gfet4t7; dur=442
transfer-encoding:
- chunked
vary:
- Origin
- X-Origin
- Referer
parsed_body:
candidates:
- avgLogprobs: -0.09825141863389449
content:
parts:
- text: |
I am sorry, I cannot fulfill this request. The age needs to be greater than 18.
role: model
finishReason: STOP
modelVersion: gemini-2.0-flash
usageMetadata:
candidatesTokenCount: 22
candidatesTokensDetails:
- modality: TEXT
tokenCount: 22
promptTokenCount: 108
promptTokensDetails:
- modality: TEXT
tokenCount: 108
totalTokenCount: 130
status:
code: 200
message: OK
version: 1
Loading