-
Notifications
You must be signed in to change notification settings - Fork 203
feat: Add response api to gen_ai.input.messages and gen_ai.output.messages #1650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c68750f
Update LLM SDK instrumentations for better otel semantic convention c…
dmontagu 43ba96c
Update to set gen_ai.input.messages and gen_ai.output.messages instea…
brightsparc e6e305a
Re-add inputs_to_events and responses_output_events for openai_agents…
brightsparc 9ad3829
Update test snapshots for new semantic convention attributes
brightsparc 9728871
Update test_anthropic_bedrock snapshot for new semantic convention at…
brightsparc a47faf8
Use IsJson() wrapper for gen_ai message attributes in tests
brightsparc 45e8669
Convert remaining gen_ai message attributes to use IsJson() in tests
brightsparc 622f804
Fix formatting
brightsparc 2e4ad43
Fix pyright
brightsparc 55bc09d
Use types with convert_openai_response_to_semconv, increase coverage
brightsparc 1f7304b
Fix coverage
brightsparc 9e846e9
Addressed comment for parse_json_attributes=True, added TypedDict to…
brightsparc ceec303
Fix format
brightsparc 8df81ab
Fix pyright
brightsparc 27b0dbf
Fix typing_extensions import for python 3.9
brightsparc 9988939
Use union since python 3.9 doesn't support pipe
brightsparc b657c6f
Fix linting
brightsparc 2fa8fed
Update operation.name to be unique for different openai methods
brightsparc 3aef5b9
Fix coverage
brightsparc 69cd76f
Update coverage
brightsparc 709fc9d
Fix connection issues, will next split off PRs
brightsparc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the kind of thing I'm talking about when I say:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I will work on breaking this up into 3 PRs.
Once I have these I will link to this PR and it can be closed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 and 3 can stay together
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 3 PRS are
I suggest we land them in this order, as the input/output do overlap a bit and may need to rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I missed this message, will combine 3 into 2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closing in favour of #1657 and #1666