Add OTel GenAI semantic convention attributes to LLM instrumentations#1619
Merged
alexmojaki merged 7 commits intopydantic:mainfrom Jan 13, 2026
Merged
Conversation
Contributor
jimilp7
commented
Jan 9, 2026
jimilp7
commented
- Add SpanKind.CLIENT to LLM spans (was INTERNAL)
- Add gen_ai.provider.name attribute ('openai' or 'anthropic')
- Add gen_ai.request.* parameter attributes:
- max_tokens, temperature, top_p, top_k
- stop_sequences, seed, frequency_penalty, presence_penalty
- Add gen_ai.tool.definitions attribute when tools are provided
- Add semconv.py constants file for GenAI semantic conventions
- Update test snapshots for new attributes
- Add SpanKind.CLIENT to LLM spans (was INTERNAL)
- Add gen_ai.provider.name attribute ('openai' or 'anthropic')
- Add gen_ai.request.* parameter attributes:
- max_tokens, temperature, top_p, top_k
- stop_sequences, seed, frequency_penalty, presence_penalty
- Add gen_ai.tool.definitions attribute when tools are provided
- Add semconv.py constants file for GenAI semantic conventions
- Update test snapshots for new attributes
jimilp7
force-pushed
the
add-genai-semconv-attributes
branch
from
532d296 to
c1dd023
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jimilp7
force-pushed
the
add-genai-semconv-attributes
branch
from
76292a5 to
50af26d
Compare
alexmojaki
reviewed
Jan 12, 2026
| # Ensure that `{request_data[model]!r}` doesn't raise an error, just a warning about `model` missing. | ||
| json_data = {} | ||
| raw_json_data = {} | ||
| json_data = cast('dict[str, Any]', raw_json_data) |
Contributor
There was a problem hiding this comment.
is this raw_json_data variable needed just to deal with pyright quirks?
Contributor
Author
There was a problem hiding this comment.
pyright quirks, please advise
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds OpenTelemetry GenAI semantic convention attributes to LLM instrumentations for OpenAI and Anthropic providers. The changes align the implementation with OTel semantic conventions for generative AI operations.
Changes:
- Changed span kind from INTERNAL to CLIENT for all LLM API calls
- Added
gen_ai.provider.nameattribute identifying the LLM provider ('openai' or 'anthropic') - Added request parameter extraction for max_tokens, temperature, top_p, top_k, stop_sequences, seed, frequency_penalty, and presence_penalty
- Added tool definitions tracking when tools/functions are provided to the LLM
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| logfire/_internal/integrations/llm_providers/semconv.py | New file defining GenAI semantic convention constant names |
| logfire/_internal/main.py | Added _span_kind parameter support to span creation methods and LogfireSpan class |
| logfire/_internal/integrations/llm_providers/llm_provider.py | Updated to use SpanKind.CLIENT for all LLM requests |
| logfire/_internal/integrations/llm_providers/openai.py | Added provider name and request parameter extraction for OpenAI endpoints |
| logfire/_internal/integrations/llm_providers/anthropic.py | Added provider name and request parameter extraction for Anthropic endpoints |
| tests/otel_integrations/test_openai.py | Updated test snapshots for new attributes and added parameter extraction tests |
| tests/otel_integrations/test_anthropic.py | Updated test snapshots for new attributes and added parameter extraction tests |
| tests/otel_integrations/test_anthropic_bedrock.py | Updated test snapshots for new attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Add |
jimilp7
force-pushed
the
add-genai-semconv-attributes
branch
from
7f6be64 to
130c1b6
Compare
jimilp7
force-pushed
the
add-genai-semconv-attributes
branch
from
130c1b6 to
b34af6b
Compare
Contributor
Author
|
@alexmojaki added |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.