Minor: do not extract heap threshold values if not updating filter#37
Merged
adriangb merged 1 commit intopydantic:topk-filtersfrom Aug 22, 2025
Merged
Minor: do not extract heap threshold values if not updating filter#37adriangb merged 1 commit intopydantic:topk-filtersfrom
adriangb merged 1 commit intopydantic:topk-filtersfrom
Conversation
alamb
commented
Aug 22, 2025
| // Extract scalar values BEFORE acquiring lock to reduce critical section | ||
| let thresholds = match self.heap.get_threshold_values(&self.expr)? { | ||
| Some(t) => t, | ||
| None => return Ok(()), |
Author
There was a problem hiding this comment.
this was an early return, but I was thinking that extracting the values can be delayed until after we decided if an update is needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets apache#16433 from @adriangb
While reviewing apache#16433 I noticed we could skip extracting topk values as scalars if we aren't going to be updating the value