Skip to content

Fix ArrowReaderOptions should read with physical_file_schema so we do… #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

Fix ArrowReaderOptions should read with physical_file_schema so we do… #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5179e38
Fix ArrowReaderOptions should read with physical_file_schema so we do…
zhuqi-lucas Apr 4, 2025
d30bf38
Fix fmt
zhuqi-lucas Apr 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion datafusion/datasource-parquet/src/opener.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ impl FileOpener for ParquetOpener {
metadata,
&mut reader,
// Since we're manually loading the page index the option here should not matter but we pass it in for consistency
ArrowReaderOptions::new().with_page_index(true),
ArrowReaderOptions::new()
.with_page_index(true)
.with_schema(physical_file_schema.clone()),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a nice catch

)
.await?;
}
Expand Down