Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix description for array-like fields #184

Merged
merged 4 commits into from
Apr 24, 2024
Merged

Fix description for array-like fields #184

merged 4 commits into from
Apr 24, 2024

Conversation

sergue1
Copy link
Contributor

@sergue1 sergue1 commented Feb 12, 2024

Fixes #178

@codecov Codecov
Copy link

codecov bot commented Feb 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@sergue1 sergue1 force-pushed the fix-array-field-description branch from b9bf601 to e24b06c Compare February 12, 2024 14:54
@tim-x-y-z
Copy link
Contributor

I think this also applies to other field - in particular had an error with json_schema now here

samuelcolvin
samuelcolvin reviewed Feb 14, 2024
View reviewed changes
Copy link
Member

@samuelcolvin samuelcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

sydney-runkle
sydney-runkle approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sergue1,

Looks good, though the line on 313 isn't covered by the newly added test - is it necessary?

@sergue1
Copy link
Contributor Author

sergue1 commented Apr 22, 2024

@sydney-runkle , I am a bit confused that 313 line is uncovered: revert it and the newly added test will fail as expected. May be it is an issue with codecov?

@sydney-runkle
Copy link
Member

Huh, odd! Yeah, maybe an issue. I'll see if I can try to skip that check for this PR.

@sydney-runkle
Copy link
Member

Ah ok I think perhaps this is because we changed a line that was not covered before?

@sergue1 sergue1 force-pushed the fix-array-field-description branch from 06276f0 to 6e82a89 Compare April 23, 2024 19:36
sydney-runkle
sydney-runkle approved these changes Apr 24, 2024
View reviewed changes
Copy link
Member

@sydney-runkle sydney-runkle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sydney-runkle sydney-runkle merged commit a19d7bf into pydantic:main Apr 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samuelcolvin samuelcolvin samuelcolvin left review comments

@sydney-runkle sydney-runkle sydney-runkle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Select description gets attached to multiple field
4 participants
@sergue1 @tim-x-y-z @sydney-runkle @samuelcolvin