Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add an option to use POST for search_issues #1723

Merged
merged 1 commit into from
Dec 21, 2023
Merged

feat: add an option to use POST for search_issues #1723

merged 1 commit into from
Dec 21, 2023

Conversation

BlankTiger
Copy link
Contributor

Addresses #701 and #548. Gives user an option to use POST endpoint instead of GET endpoint for fetching issues.

@adehad adehad linked an issue Sep 28, 2023 that may be closed by this pull request
Send search request as POST for large queries #701
Closed
adehad
adehad approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, appreciate the quality of this PR. It sounds like we may want to consider updating the docs to help people recognize when they might want to use this flag too.

For now merging !

@adehad adehad merged commit 9206b3e into pycontribs:main Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Send search request as POST for large queries
2 participants
@BlankTiger @adehad