Use user_id when adding watcher #1682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
adehad
approved these changes
Jun 29, 2023
|
This was a breaking change, and shouldn't this be backwards compatible? Adding a fix to search for user ID using email adds an API call when I already have the user IDs. Can we verify the format first, and accept both? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this is related to #1431
The
add_watchermethod is failing when using a user name. I tried with v2 and v3 of the Cloud API. It worked with the user ID though. I believe this is related to Jira's GDPR issues.Added a simple fix to retrieve the ID before adding the watcher. This is already done in the
delete_watchermethod.