Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create_project docstring #1676

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Update create_project docstring #1676

merged 3 commits into from
Jun 6, 2023

Conversation

ABizzinotto
Copy link
Contributor

The docstring for create_project is outdated. This PR:

  • updates the docstring to include all listed parameters
  • adds type hints to the parameters that did not have them
  • adds support for using categoryId instead of projectCategory

Addresses issue #1132

@adehad adehad linked an issue Jun 6, 2023 that may be closed by this pull request
docstring of create_project is not up to date #1132
Closed
adehad
adehad approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@adehad adehad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thanks for the contribution

@adehad adehad merged commit e781330 into pycontribs:main Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docstring of create_project is not up to date
2 participants
@ABizzinotto @adehad