Switch from SIGNATURE_RSA to SIGNATURE_HMAC_SHA1 #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you add the label.... ? |
RHEL 9 has a policy of deprecating SHA1 and has removed it from python-oauthlib via the addition of locally added patch. Switching to SIGNATURE_RSA_HMAC_SHA1 allows this module to be used on RHEL9 when the system package python3-oauthlib-3.1.1-2.el9.noarch.rpm is used.
for more information, see https://pre-commit.ci
traylenator
changed the title
Governa
added a commit
to Governa/jira
that referenced
this pull request
Jun 1, 2023
PR pycontribs#1643 changed the default signature_method from SIGNATURE_RSA to SIGNATURE_HMAC_SHA1. This was done to keep compatibility with RHEL. The problem is that some Jira servers don't accept SIGNATURE_HMAC_SHA1 and there's currently no way for the user to choose which method to use. This PR adds a new, optional, field that can be passed to the `oauth` parameter and allows the user to choose which signature_method they want.
Governa
added a commit
to Governa/jira
that referenced
this pull request
Jun 1, 2023
PR pycontribs#1643 changed the default signature_method from SIGNATURE_RSA to SIGNATURE_HMAC_SHA1. This was done to keep compatibility with RHEL. The problem is that some Jira servers don't accept SIGNATURE_HMAC_SHA1 and there's currently no way for the user to choose which method to use. This PR adds a new, optional, field that can be passed to the `oauth` parameter and allows the user to choose which signature_method they want.
Governa
added a commit
to Governa/jira
that referenced
this pull request
Jun 1, 2023
PR pycontribs#1643 changed the default signature_method from SIGNATURE_RSA to SIGNATURE_HMAC_SHA1. This was done to keep compatibility with RHEL. The problem is that some Jira servers don't accept SIGNATURE_HMAC_SHA1 and there's currently no way for the user to choose which method to use. This PR adds a new, optional, field that can be passed to the oauth parameter and allows the user to choose which signature_method they want.
This was referenced Jun 1, 2023
4 tasks
|
This breaks existing software. Against Jira Server |
adehad
pushed a commit
that referenced
this pull request
Jun 6, 2023
PR #1643 changed the default signature_method from SIGNATURE_RSA to SIGNATURE_HMAC_SHA1. This was done to keep compatibility with RHEL. The problem is that some Jira servers don't accept SIGNATURE_HMAC_SHA1 and there's currently no way for the user to choose which method to use. This PR adds a new, optional, field that can be passed to the oauth parameter and allows the user to choose which signature_method they want.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RHEL 9 has a policy of deprecating SHA1 and has removed it from python-oauthlib via the addition of locally added patch.
Switching to SIGNATURE_RSA_HMAC_SHA1 allows this module to be used on RHEL9 when the system package python3-oauthlib-3.1.1-2.el9.noarch.rpm is used.
Here is the patch form RHEL9 python-oauthlib.
0001-Rip-out-RSA-SHA1.patch.txt