Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix verify not sent with request (#1573) #1631

Merged
merged 1 commit into from
May 17, 2023
Merged

fix verify not sent with request (#1573) #1631

merged 1 commit into from
May 17, 2023

Conversation

jongracecox
Copy link
Contributor

This commit fixes an issue where the verify option is not passed along with requests issued by the ResilientSession class. This commit adds the verify option into the request args inside the _jira_prepare function.

The commit includes a unit test that verifies that session.verify is correclty handed over to requests during subsequent Jira API calls.

@jongracecox
Copy link
Contributor Author

Could someone please add the bug label to this PR? I don't have permission to do so.

@studioj studioj added the bug label Mar 27, 2023
@studioj
Copy link
Collaborator

studioj commented Mar 27, 2023

thanks for the PR

studioj
studioj previously approved these changes Mar 27, 2023
View reviewed changes
@jongracecox
Copy link
Contributor Author

It's not clear to me why the ci / cloud / py3.8 tests are failing, but I notice the same errors on other PRs (#1528), so wonder whether this is not specific to this PR.

@jongracecox
fix verify not sent with request (pycontribs#1573)
d1b413f 
This commit fixes an issue where the `verify` option is not passed along
with requests issued by the ResilientSession class. This commit adds the
`verify` option into the request args inside the `_jira_prepare`
function.

The commit includes a unit test that verifies that `session.verify` is
correclty handed over to requests during subsequent Jira API calls.
@jongracecox jongracecox force-pushed the jongracecox/fix-verify-not-sent branch from ae35a3f to d1b413f Compare March 28, 2023 13:26
@jongracecox
Copy link
Contributor Author

It's not clear to me why the ci / cloud / py3.8 tests are failing, but I notice the same errors on other PRs (#1528), so wonder whether this is not specific to this PR.

I assume it because my PR doesn't have access to the project secrets, so doesn't need anything fixed from my side.

@adehad
Copy link
Contributor

adehad commented May 17, 2023

It's not clear to me why the ci / cloud / py3.8 tests are failing, but I notice the same errors on other PRs (#1528), so wonder whether this is not specific to this PR.

I assume it because my PR doesn't have access to the project secrets, so doesn't need anything fixed from my side.

Exactly the case, sorry for the delay. Thanks for the great quality PR!

@adehad adehad linked an issue May 17, 2023 that may be closed by this pull request
SSL Certificate Not Sent #1573
Closed
4 tasks
@adehad adehad merged commit 916fced into pycontribs:main May 17, 2023
@jongracecox jongracecox deleted the jongracecox/fix-verify-not-sent branch May 17, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adehad adehad adehad approved these changes

@studioj studioj studioj left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SSL Certificate Not Sent
3 participants
@jongracecox @studioj @adehad