Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add visibility argument #1552

Merged
merged 1 commit into from
Dec 21, 2023
Merged

add visibility argument #1552

merged 1 commit into from
Dec 21, 2023

Conversation

@adehad adehad added the feature label Nov 17, 2022
@adehad adehad self-assigned this Nov 17, 2022
@adehad adehad temporarily deployed to cloud November 17, 2022 20:27 Inactive
Copy link
Collaborator

@studioj studioj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest looks good :) a little test would be nice

jira/client.py Outdated
@@ -2359,6 +2360,13 @@ def add_worklog(
comment (Optional[str]): optional worklog comment
started (Optional[datetime.datetime]): Moment when the work is logged, if not specified will default to now
user (Optional[str]): the user ID or name to use for this worklog
visibility (Optional[Dict[str,Any]]): the visibility argument. ::
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from my perspective it would be useful to see in the docs what "visibility" actually does

@adehad adehad force-pushed the feature/add_visibility_to_add_worklog branch from 203bea6 to b5935a7 Compare December 21, 2023 18:08
@adehad adehad removed the feature label Dec 21, 2023
@adehad adehad added the minor label Dec 21, 2023
@adehad adehad merged commit 338b201 into main Dec 21, 2023
10 of 14 checks passed
@adehad adehad deleted the feature/add_visibility_to_add_worklog branch December 21, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants