Modified the type hinting for the attachment in the add_attachment fu… #1521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction to properly support BytesIo and StringIO
for more information, see https://pre-commit.ci
studioj
approved these changes
Nov 12, 2022
|
CI fails here |
|
@rpop0 there were a lot of fixes to docstrings and types merged in another PR. Could you check if yours is still an issue? |
|
@studioj Sorry for the late response but the incorrect type hinting still seems to be an issue in the latest version. I'll update this when I get the time. |
ghost
mentioned this pull request
4 tasks
|
Wouldn't it be enough to just change the type to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nction to properly support BytesIo and StringIO
This change was done due to the fact that using an object of type BytesIO or StringIO resulted in IDE warnings regarding mismatched types.