add createmeta_84age implementation

[dshvedchenko]

this is draft for implementation of createmeta required according to changes causing #1462

[adehad]

Great start !!
Made some comments, it would also be great if we can get some tests in, let me know if you need help on that front.
I would have a look at the tests/resources/ folder

[adehad]

Suggested change

status_code=500,

We shouldn't try and set our own status code. I would just let this exception bubble up

[adehad]

We could instead use the existing methods on the client to check if a project exists, for example like so:

jira/tests/conftest.py

Line 202 in 7846ac3

def _project_exists(self, project_key: str) -> bool:

Might be making this its own method, and use it in the test harness as well.

[adehad]

@studioj did we decide what we wanted to do with the naming convention of new functions?

[adehad]

We definitely cannot use a function name called _v2.

Let's instead deprecate at the argument level.

e.g.
User passes projectKeys as a List[str]
if version > 9 raise ValueError
else if version is >8.4 - raise deprecation warning
The deprecation warning can be more detailed, explaining exactly what is wrong with the arguments and must include a link to the Atlassian docs where they describe this deprecation, ie: https://confluence.atlassian.com/jiracore/createmeta-rest-endpoint-to-be-removed-975040986.html

I might structure it like this:

def createmeta(...): 
    is_deprecation_msg_raised = false
    def deprecate_or_raise(msg: str):
        if self._version >= (9, 0, 0):
            raise ValueError(msg)
        elif self._version >= (9, 0, 0):
            DeprecationWarning(f"From Jira version 9.0.0: {msg}") # might need to change the stacklevel for this to work as intended

    if not isinstance(projectKeys, str) or ("," in projectKeys):
        deprecate_or_raise("projectKeys must be a str of a single project key")

    # and so on for other
    ...

    if is_deprecation_msg_raised :
        DeprecationWarning(
            "Atlassian wil have deprecated the `/createmeta` endpoint in Jira version 9.0.0."
            + "Full details can be found on:"
            + "https://confluence.atlassian.com/jiracore/createmeta-rest-endpoint-to-be-removed-975040986.html"
        )

In the above proposal, people will be warned about ways they can change the calls in preparation. Feel free to use another method if more appropriate

[dshvedchenko]

sorry, i have to skip this activity till war in Ukraine is finished

[Ry-DS]

@dshvedchenko sorry to hear you're affected 😔 hope all is well for you! If you give write access to your fork, I'm more than happy to finish the job :)

[pmilosev]

I need this fix and will invest couple of days on it ... I'll try to reproduce a similar solution accounting for the comments provided here.

[dshvedchenko]

need suggestions on how to automate tests for this.
current ci server is still 8.17 so can not be used to test on 9.0.0 jira branch

edit : https://github.com/pycontribs/jira/blob/main/.github/workflows/jira_server_ci.yml#L15

[dshvedchenko]

can we have a progress on this or on #1527 PRs

[adehad]

Thank you again for all the effort on this PR @dshvedchenko, sorry that we went with the alternative PR this time. Hope you can contribute again in the future !