-
-
Notifications
You must be signed in to change notification settings - Fork 877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove setup.py and tidy build scripts #1443
Conversation
@adehad That is one dangerous move as the full-pyproject support is very new in pip, likely will cause problems for many people. |
On the other hand, I do fully support removal of |
My understanding is pretty limited, but I would have thought it wouldn't be a problem to most users as they would use the pypi wheels? Would be great to know a bit about what kinds of failures we can expect to see from your experience @ssbarnea I know asottile also has strong opinions on this topic and prefers not even having the presence of the pyproject file as pip completely changes its behaviour when it sees it.... |
Hehe... most of his opinions are strong. I will try to give a hand later this week, now I am quite busy dealing with too many tasks in parallel. For the moment I would recommend matching what we do on https://github.com/ansible/ansible-lint/blob/main/tox.ini -- where we removed setup.py, but did not fully migrate to pyproject.toml, making full use of setuptools-scm. |
9657db6
to
9726059
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do NOT move to pyproject.toml, editable installs still do not work. There is a setuptools PR that is open for fixing them.
9726059
to
5a5e183
Compare
re-running to check if codecov will fix itsef |
9e05bdb
to
59842e9
Compare
@ssbarnea would be great if you have a chance for a second look on this |
This dependency is not needed. The documentation at https://github.com/Changaco/setuptools_scm_git_archive states that there are two files needed for this to work .git_archival.txt and .gitattributes. Both files are missing in this repository. See also #1365
c9a9bcd
to
be3d8af
Compare
Change Summary
setup.py
(would have kept it if we were usingpyproject.toml
, per the guidance from setuptools docs to preserve editable install behaviour across older pip's)pyproject.toml
where possible, only flake8 remains insetup.cfg
No password provided\n assert ''\n
, but somehow becameNo password provided\n
. I've moved this to a simpleValueError
as assertion's aren't really a great way to surface these kinds of problems. (e.g. if someone runs with-O
for whatever reason)setup.cfg
removing duplicates that made their way topyproject.toml
( and the removedsetup.py
)Testing the git archive can be performed using: