This repository was archived by the owner on Sep 16, 2024. It is now read-only.
Fixes an SSL / TLS socket blocking problem #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout is 0 (non-blocking)…
|
Looks good, thanks! |
|
Merged! |
X-Ryl669
pushed a commit
to X-Ryl669/pycom-micropython-sigfox
that referenced
this pull request
May 12, 2023
Minor fixes in BLE and LoRa
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why the "MBEDTLS_ERR_SSL_TIMEOUT" is thrown after a connection has succeeded. However, the "do nothing" loop in combination with this error in "wlan_socket_recv" was causing the socket to block even when the timeout was set to 0. Catching this error and returning zero bytes on a non-blocking ssl socket seems to work. I tested this quickly with a self signed cert on a node.js server...
If this seems too "hacky" then mbedtls needs debugged and modified appropriately. The mbedtls code is wrapped up in a library at the moment so the source is not readily available in the tree...