[LoRaWAN] Error in LoRaMacChannelManualAdd

[quentin-ol]

Hello,

I've spotted an error in LoRaMac.c:

LoRaMacStatus_t LoRaMacChannelManualAdd( uint8_t id, ChannelParams_t params )
{
  [...]
        if( ValueInRange( params.DrRange.Fields.Max, DR_5, LORAMAC_TX_MAX_DATARATE ) == false )
        {
            datarateInvalid = true;
        }
    }
[....]

DR_5 should be replaced by DR_0.

In the current state, this prevents forcing the LoPy to lower its max data rate.

[danicampora]

Thanks, we will fix it!

[dmartauz]

Does it mean that OTAA join is performed at DR_5 as well?

[jmarcelino]

@dmartauz this was only related to adding channels manually.

The corrections were integrated already in eca3b71

Thanks for the report @quentin-ol

[dmartauz]

@jmarcelino
Is there any documentation describing which data rates are used during OTAA join and what is the sequence?