Skip to content
This repository was archived by the owner on Sep 16, 2024. It is now read-only.
This repository was archived by the owner on Sep 16, 2024. It is now read-only.

AU915 and US915 region code is too restrictive when adding 500kHz BW channels #163

Open
@Bdanilko

Description

@Bdanilko

System I'm using:
(sysname='LoPy4', nodename='LoPy4', release='1.17.3.b1', version='ae3a294-dirty on 2018-05-01', machine='LoPy4 with ESP32', lorawan='1.0.2', sigfox='1.0.1')
I've done a new version of the firmware to test my 'fix' -- but the issue was definitely in the original 1.17.3.b1 firmware.

When adding a single 500kHz channel for the AU915 (id 64-71), it is not added:
self.lora.add_channel(65, frequency=917500000, dr_min=6, dr_max=6)

The issue seems to be that the function:
RegionAU915ChannelManualAdd( ChannelAddParams_t* channelAdd )
enforces that the dr_min has to be 0 for ALL channels. But for the AU915 and US915 channel id's 64-71, the dr_min is not meant to be zero (for AU915 it is DR6 and US915 it is DR4).

This results in the channel silently being discarded on the add_channel() call, so not being available for transmission.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions