fix: handle watcher .update() in case of async definition #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was trying to use
casbin-async-postgres-watcherwith an AsyncEnforcer, and it appears that the enforcer watcher update call was sync, but the async-postgres-watcher is async, warned by the followingWhat
I decided to refactor the AsyncInternalEnforcer to handle update in case of an async definition, while doing this I found out that I can reduce some code duplications.
To Reproduce
pseudo-snippet