Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete rand.py #675

Merged
merged 8 commits into from
Jul 25, 2017
Merged

Delete rand.py #675

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
43f5a90
Delete rand.py
alex Jul 23, 2017
c740f6f
Delete test_rand.py
alex Jul 23, 2017
125cda7
Remove rand import
alex Jul 23, 2017
4f5e09d
changelog entry
alex Jul 23, 2017
77e5ab1
empty commit to retrigger travis
alex Jul 23, 2017
b65baec
Merge branch 'master' into alex-patch-1
alex Jul 25, 2017
d1ac750
Expand message, also semantic newlines for @hynek
alex Jul 25, 2017
bdee330
spelling
alex Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'master' into alex-patch-1
  • Loading branch information
@alex
alex authored Jul 25, 2017
commit b65baec0e7485b1a94e545ffae3f9d1e270f43a6
2 changes: 2 additions & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ The third digit is only for regressions.
Backward-incompatible changes:
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

- Dropped support for Python 3.3.
`#677 <https://github.com/pyca/pyopenssl/pull/677>`_
- Removed the deprecated ``OpenSSL.rand`` module. ``os.urandom`` should be used instead.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  1. add a rationale why we choose to disregard our own policy (1 sentence is just fine)
  2. make it os.urandom() – marking functions/methods with parentheses is nicer to read/understand.

thanks!

`#675 <https://github.com/pyca/pyopenssl/pull/675>`_

Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.