Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't assign to names that aren't used #1356

Merged
merged 1 commit into from
Aug 11, 2024
Merged

Don't assign to names that aren't used #1356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions tests/test_ssl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,8 +1525,7 @@ def _use_certificate_chain_file_test(self, certdir):
it with a client which trusts cacert and requires verification to
succeed.
"""
chain = _create_certificate_chain()
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
[(_, cacert), (_, icert), (skey, scert)] = _create_certificate_chain()

makedirs(certdir)

Expand Down Expand Up @@ -2470,7 +2469,7 @@ def test_shutdown_closed(self):
If the underlying socket is closed, `Connection.shutdown` propagates
the write error from the low level write call.
"""
server, client = loopback()
server, _ = loopback()
server.sock_shutdown(2)
with pytest.raises(SysCallError) as exc:
server.shutdown()
Expand Down Expand Up @@ -2554,8 +2553,7 @@ def test_get_certificate(self):
"""
`Connection.get_certificate` returns the local certificate.
"""
chain = _create_certificate_chain()
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
[_, _, (_, scert)] = _create_certificate_chain()

context = Context(SSLv23_METHOD)
context.use_certificate(scert)
Expand Down Expand Up @@ -2587,8 +2585,7 @@ def test_get_peer_cert_chain(self):
`Connection.get_peer_cert_chain` returns a list of certificates
which the connected server returned for the certification verification.
"""
chain = _create_certificate_chain()
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
[(_, cacert), (_, icert), (skey, scert)] = _create_certificate_chain()

serverContext = Context(SSLv23_METHOD)
serverContext.use_privatekey(skey)
Expand Down Expand Up @@ -2647,8 +2644,7 @@ def test_get_verified_chain(self):
`Connection.get_verified_chain` returns a list of certificates
which the connected server returned for the certification verification.
"""
chain = _create_certificate_chain()
[(cakey, cacert), (ikey, icert), (skey, scert)] = chain
[(_, cacert), (_, icert), (skey, scert)] = _create_certificate_chain()

serverContext = Context(SSLv23_METHOD)
serverContext.use_privatekey(skey)
Expand Down Expand Up @@ -2759,7 +2755,7 @@ def test_server_get_session(self):
On the server side of a connection, `Connection.get_session` returns a
`Session` instance representing the SSL session for that connection.
"""
server, client = loopback()
server, _ = loopback()
session = server.get_session()
assert isinstance(session, Session)

Expand All @@ -2769,7 +2765,7 @@ def test_client_get_session(self):
returns a `Session` instance representing the SSL session for
that connection.
"""
server, client = loopback()
_, client = loopback()
session = client.get_session()
assert isinstance(session, Session)

Expand Down Expand Up @@ -2813,7 +2809,7 @@ def makeClient(socket):
client.set_session(originalSession)
return client

resumedServer, resumedClient = loopback(
resumedServer, _ = loopback(
server_factory=makeServer, client_factory=makeClient
)

Expand Down Expand Up @@ -2851,7 +2847,7 @@ def makeOriginalClient(socket):
client.set_connect_state()
return client

originalServer, originalClient = loopback(
_, originalClient = loopback(
server_factory=makeServer, client_factory=makeOriginalClient
)
originalSession = originalClient.get_session()
Expand All @@ -2872,7 +2868,7 @@ def test_wantWriteError(self):
`OpenSSL.SSL.WantWriteError` if writing to the connection's BIO
fail indicating a should-write state.
"""
client_socket, server_socket = socket_pair()
client_socket, _ = socket_pair()
# Fill up the client's send buffer so Connection won't be able to write
# anything. Start by sending larger chunks (Windows Socket I/O is slow)
# and continue by writing a single byte at a time so we can be sure we
Expand Down Expand Up @@ -2926,7 +2922,7 @@ def test_get_finished(self):
from client, or server. Finished messages are send during
TLS handshake.
"""
server, client = loopback()
server, _ = loopback()

assert server.get_finished() is not None
assert len(server.get_finished()) > 0
Expand All @@ -2937,7 +2933,7 @@ def test_get_peer_finished(self):
message received from client, or server. Finished messages are send
during TLS handshake.
"""
server, client = loopback()
server, _ = loopback()

assert server.get_peer_finished() is not None
assert len(server.get_peer_finished()) > 0
Expand Down Expand Up @@ -3402,7 +3398,7 @@ def test_closed(self):
If the underlying socket is closed, `Connection.sendall` propagates the
write error from the low level write call.
"""
server, client = loopback()
server, _ = loopback()
server.sock_shutdown(2)
with pytest.raises(SysCallError) as err:
server.sendall(b"hello, world")
Expand Down