Use openssl_assert for error handling in more places

pyca · Aug 5, 2024 · 1769c4a · 1769c4a
1 parent 3ada747
commit 1769c4a
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/src/OpenSSL/crypto.py b/src/OpenSSL/crypto.py
@@ -1665,8 +1665,7 @@ def add_extensions(
                 raise ValueError("One of the elements is not an X509Extension")
 
             add_result = _lib.X509_add_ext(self._x509, ext._extension, -1)
-            if not add_result:
-                _raise_current_error()
+            _openssl_assert(add_result == 1)
 
     def get_extension(self, index: int) -> _X509ExtensionInternal:
         """
@@ -1777,9 +1776,7 @@ def add_crl(
 
             bio = _new_mem_buf(crl.public_bytes(Encoding.DER))
             openssl_crl = _lib.d2i_X509_CRL_bio(bio, _ffi.NULL)
-            if openssl_crl == _ffi.NULL:
-                _raise_current_error()
-
+            _openssl_assert(openssl_crl != _ffi.NULL)
             crl = _ffi.gc(openssl_crl, _lib.X509_CRL_free)
         elif isinstance(crl, _CRLInternal):
             crl = crl._crl