Move extension encoding code to new crate x509::extensions #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixfontein
force-pushed
the
extensions
branch
from
f827515
to
b30b89c
Compare
felixfontein
changed the title
reaperhulk
reviewed
Nov 10, 2021
reaperhulk
reviewed
Nov 10, 2021
|
The more I look at this the more I'm sure we need to also merge the parsers if this is the direction we're going, but I think that should be a subsequent PR. What do you think about putting all the OIDs in one spot? Maybe we need an |
felixfontein
force-pushed
the
extensions
branch
from
6152df5
to
4acce97
Compare
felixfontein
force-pushed
the
extensions
branch
from
e8bedcf
to
fd00078
Compare
reaperhulk
approved these changes
Nov 10, 2021
|
@reaperhulk thanks for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6346 (comment).