Move pkg_resources import location. #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsully, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Ayrx, @reaperhulk and @public to be potential reviewers. |
|
Jenkins, ok to test |
|
Is there an upstream ticket on pkg_resources about this issue? |
|
(Tests are failing while we wait for a new coverage release, you don't need to do anything) |
|
@alex Not as of yet. |
|
Ok. While merging this eventually is fine, I'm going to object to us
merging this until there's been a bug filed in pkg_resources.
…On Tue, Jan 17, 2017 at 12:00 AM, Dan Sully ***@***.***> wrote:
@alex <https://github.com/alex> Not as of yet.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3347 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAADBCcEXVH8dvw8FOHBBlrTky75-EL2ks5rTErfgaJpZM4LlNWn>
.
--
"I disapprove of what you say, but I will defend to the death your right to
say it." -- Evelyn Beatrice Hall (summarizing Voltaire)
"The people's good is the highest law." -- Cicero
GPG Key fingerprint: D1B3 ADC0 E023 8CA6
|
|
Jenkins, retest this please. |
reaperhulk
approved these changes
Jan 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the requests PR thread.