Use mitmproxy's uv.lock for downstream tests #13022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Jun 1, 2025
alex
reviewed
Jun 1, 2025
.github/downstream.d/mitmproxy.sh
Outdated
| cd mitmproxy | ||
| git rev-parse HEAD | ||
| uv pip install --system --group dev -e . | ||
| uv pip install --system --requirements <(uv export) -e . |
Member
There was a problem hiding this comment.
Suggested change
| uv pip install --system --requirements <(uv export) -e . | |
| uv pip install --system --requirements <(uv export --group dev) -e . |
Should we do this?
Member
Author
There was a problem hiding this comment.
dev is a default group, so those dependencies are already included. We can do this if you think it's more readable, but it's functionally equivalent. :)
alex
approved these changes
Jun 2, 2025
alex
pushed a commit
to alex/cryptography
that referenced
this pull request
Aug 5, 2025
* use mitmproxy's uv.lock for downstream tests * add `--locked`
reaperhulk
pushed a commit
that referenced
this pull request
Aug 5, 2025
* Bump for 45.0.6 release * Use mitmproxy's uv.lock for downstream tests (#13022) * use mitmproxy's uv.lock for downstream tests * add `--locked` * install deps for downstream tests into a venv with uv (#13192) * install deps for downstream tests into a venv with uv * this needs to use the venv pyhon too * stop trying to do shell hijinx * install pip for certbot * fall back o regular pip someimes * try to get cryptography installed into the venv for scapy * allow us to debug * fix override syntax * oops, one fewer * computer * try fixing paramiko dev (#13239) * hack to fix coverage (#13161) * hack to fix coverage * Update ci.yml * Update ci.yml * Update ci.yml * Attempt to fix coverage due to rust nonsense (#13153) * attempt to fix inane coverage nonsense (#13156) * coverage fix, cherry pick of dac3653 --------- Co-authored-by: Maximilian Hils <git@maximilianhils.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make things more stable going forward. :-)