Release GIL during cipher update #11900
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you share anything about the performance impact of this? I'm modestly nervous about performance overhead for very small chunks, but what can you do 🙃 |
alex
reviewed
Nov 5, 2024
Releasing the GIL should be order of microseconds. I could put together a benchmark for small blocks to see if the overhead is meaningful |
alex
approved these changes
Nov 5, 2024
|
Ooops, crossed streams :-) Do you have any numbers for the impact of this on your application? |
|
I can get some for you hopefully tonight, thanks for the quick review! |
|
Sounds great, thanks for the contribution |
|
Just a quick ping re: perf numbers 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to discussion in #11585.