argon2id support #11524
Merged
argon2id support #11524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Sep 2, 2024
reaperhulk
force-pushed
the
argon2id
branch
7 times, most recently
from
66a4b4a
to
e37c3df
Compare
alex
reviewed
Oct 22, 2024
reaperhulk
force-pushed
the
argon2id
branch
4 times, most recently
from
5942c95
to
70351ce
Compare
alex
reviewed
Oct 29, 2024
alex
reviewed
Nov 5, 2024
|
@reaperhulk I see that this is marked draft. Is it ready for review, or are there still TODOs? |
|
This is now reviewable |
|
That said, if there are no comments let’s not merge, I want a final pass myself since this has gone so long. I already see some doc improvements I could make |
alex
reviewed
Nov 10, 2024
Comment on lines
+126
to
+127
| if self._fips_enabled: | ||
| return False |
alex
reviewed
Nov 11, 2024
Co-authored-by: Alex Gaynor <alex.gaynor@gmail.com>
alex
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a rust-openssl release