Solution C02 I fixed a bug that was mutating the draw list during validation. #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a test to check for a mutated draw during validation.
yothenberg
changed the title
yothenberg
changed the title
|
Nice, thank you |
|
Good catch, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _validation function accepts the draw list and then mutates it by removing letters. Subsequent uses of the draw list are then invalid. The unit tests didn't catch it. I fixed the bug by copying the list for local mutation and I added an assertion to check that draw is not mutated during validation.
ATTENTION: before clicking "Create Pull Request" please submit some meta data, thanks!
Difficulty level (1-10): [2]
Estimated time spent (hours): [.25]
Completed (yes/no): [yes]
I stretched my coding skills (if yes what did you learn?): [yes, itertools.permutations]
Other feedback (what can we improve?): []