Skip to content

Missing CMakelist in source tarball #769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

SylvainCorlay
Copy link
Member

Another possibility is to have conda-forge fetch the tarball from GH.

@wjakob thoughts?

@wjakob
Copy link
Member

wjakob commented Mar 28, 2017

Can you explain the context of these two PRs in more detail? I looked at both and quite frankly don't understand. (For instance, "just" the top level CMakeLists.txt is not enough to do anything, since it includes pybind11Tools, etc.)

@SylvainCorlay
Copy link
Member Author

SylvainCorlay commented Mar 28, 2017

Yes indeed, more than the CmakeLists is needed here.

@wjakob
Copy link
Member

wjakob commented Mar 28, 2017

Why are there two PRs, and how are they related? What is this trying to accomplish?

@SylvainCorlay
Copy link
Member Author

SylvainCorlay commented Mar 28, 2017

The goal of the other PR is to implement what was described in #652 i.e. enable the inclusion of the pybind11Config.cmake files in the conda package so that people building upon pybind11 who use the conda package can use find_package

@SylvainCorlay SylvainCorlay deleted the missing-file-in-tarball branch March 28, 2017 22:43
@SylvainCorlay
Copy link
Member Author

SylvainCorlay commented Mar 28, 2017

I have updated the other PR for it to fetch the tarball from GH archives, and unlike the pypi tarball, it has everything that is needed.

@wjakob
Copy link
Member

wjakob commented Mar 29, 2017

ok, sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants