-
Notifications
You must be signed in to change notification settings - Fork 2.2k
tests: run pytest under Python devmode #5715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Alright, the flaky test previously found in #5706 is caused by enabling more Python tracing. |
d54806b
to
905784a
Compare
@@ -14,6 +14,17 @@ on: | |||
required: true | |||
type: string | |||
|
|||
env: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: reusable workflows will not inherit env
from the caller workflow.
Wait for Python 3.14.0b3 release for:
to resolve the segmentation faults in tests. |
Interesting, why does it segfault under devmode? Is this indicative of a serious error I wonder? |
From the devmode docs: https://docs.python.org/3/library/devmode.html
|
I can verify that it still segfaults on the latest 3.14t (https://github.com/python/cpython/tree/5b39741a0952624ed31dfe312ad32b067353ea7b), so 3.14b3 won't fix it. |
Ohh, interesting, if I swap |
Ahh, no, I take it back, I did a proper rebuild and the latest 3.14t does work without segfault in dev mode. So yes, this is just a leftover from this bug. |
I think we need to drop the gc tests on free-threaded Python. Unless there's some way to guarantee a stop-the-world event occurs, but I believe the general option is "never rely on the gc to remove anything at some time". |
Yes. |
Thanks! |
Description
See also: https://docs.python.org/3/library/devmode.html
The Python devmode can be enabled via:
or
Suggested changelog entry: