chore: use CPython macros to construct PYBIND11_VERSION_HEX
#5683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We also read this in dynamic metadata. I don't think this can be described with regex. We could add a custom plugin; we already have What we have now (two edits to one file) is still much better than before (which also required edits to another file), though following CPython more closely sounds useful. |
|
Oh, nevermind, I see you left |
|
As long as we test somewhere that these two match (which I think we do?), I'm fine with it. |
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
henryiii
reviewed
May 23, 2025
henryiii
approved these changes
May 23, 2025
henryiii
changed the title
PYBIND11_VERSION_HEXPYBIND11_VERSION_HEX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per title, use CPython macros to construct
PYBIND11_VERSION_HEX. See also: https://github.com/python/cpython/blob/HEAD/Include/patchlevel.hSuggested changelog entry:
PYBIND11_VERSION_HEX📚 Documentation preview 📚: https://pybind11--5683.org.readthedocs.build/