feat(cmake): FindPython by default #5553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
rwgk
reviewed
Mar 6, 2025
rwgk
approved these changes
Mar 6, 2025
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
LGTM — based only on very superficial understanding
Contributor
|
I may be mistaken, but it seems as a result of this, if we the target |
Collaborator
Author
|
This is the only change recently to CMake that I know of, so it probably is the culprit, but I don't see how yet, it shouldn't have changed anything if you find Python yourself first. |
Collaborator
Author
|
AH, no, I think I see the problem. |
henryiii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This makes FindPython the default, and introduces a COMPAT mode that sets common variables to reduce breakage. FindPythonInterp/Libs was removed in CMake 3.27, and has a lot of downsides like not supporting cross compilation (like for Pyodide) properly.
Suggested changelog entry:
* Enable FindPython mode by default, with a ``COMPAT`` mode that sets some of the old variables to ease transition.