Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test C++14 on MSVC #4191

Merged
merged 1 commit into from
Sep 21, 2022
Merged

test C++14 on MSVC #4191

merged 1 commit into from
Sep 21, 2022

Conversation

Skylion007
Copy link
Collaborator

@Skylion007 Skylion007 commented Sep 20, 2022 •
edited
Loading

Description

See if C++14 works on MSVC

@Skylion007 Skylion007 mentioned this pull request Sep 20, 2022
Merged
@Skylion007 Skylion007 closed this Sep 20, 2022
@Skylion007 Skylion007 deleted the test-msvc-cpp14 branch September 20, 2022 17:28
@rwgk
Copy link
Collaborator

rwgk commented Sep 20, 2022 •
edited
Loading

Oh, closed already?

I see it worked:

C++ Info: MSVC 192930146 C++14 pybind11_internals_v4_msvc_debug

I think it would be great to merge this PR, we have plenty of CI resources to cover this as well.

@Skylion007 Skylion007 restored the test-msvc-cpp14 branch September 20, 2022 18:14
@Skylion007 Skylion007 reopened this Sep 20, 2022
rwgk
rwgk approved these changes Sep 20, 2022
View reviewed changes
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The 3 CI failures are transient tool failures. The prior run with the same state of this PR was flawless: https://github.com/pybind/pybind11/actions/runs/3092077757

I'd say good to merge.

@Skylion007 Skylion007 marked this pull request as ready for review September 21, 2022 15:19
@Skylion007 Skylion007 merged commit 95d0e71 into pybind:master Sep 21, 2022
@Skylion007 Skylion007 deleted the test-msvc-cpp14 branch September 21, 2022 15:20
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 21, 2022
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Sep 21, 2022
@rwgk rwgk mentioned this pull request Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwgk rwgk rwgk approved these changes

@henryiii henryiii Awaiting requested review from henryiii henryiii is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skylion007 @rwgk