[smart_holder] Add test_namespace_visibility #4050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests. (An earlier version of this code was used to inform PR pybind#4043.)
rwgk
changed the title
added 6 commits
July 8, 2022 10:50
…eless diagnostics.
…and CUDA `test_cross_module_exception_translator` failures).
…s action un-helpfully removed the added noqa).
…files, only setting the module docstring and doing nothing else.
…py, so that it is imported by pytest before test_exceptions.py
charlesbeattie
approved these changes
Jul 12, 2022
tests/namespace_visibility.h
Outdated
| @@ -0,0 +1,31 @@ | |||
| // Copyright (c) 2022 The Pybind Development Team. | |||
There was a problem hiding this comment.
Should this have a different extension.
I use .inc for files that are not normal header files others use .inl
There was a problem hiding this comment.
Changed to .inl:
pre-commit run --all-files clang-format did not pick up the .inc file, but it does pick up .inl without any changes elsewhere.
(A also tested this Google-internally with .inl and it worked immediately, too.)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To probe environment/toolchain/platform-specific behavior under the exact same conditions as normal tests.
(An earlier version of this code was used to inform PR #4043.)
Suggested changelog entry: