Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix cuda issue #3950

Merged
merged 4 commits into from
May 16, 2022
Merged

ci: fix cuda issue #3950

merged 4 commits into from
May 16, 2022

Conversation

henryiii
Copy link
Collaborator

Description

Suggested changelog entry:

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see this resolved, thanks!
Is this still in draft mode intentionally?

@henryiii
Copy link
Collaborator Author

Yeah, just because I'm doing a little MSVC exploration here too. :D (and the first commit didn't work, 11.4 & 11.3 break due to spewing unused variable warnings and other things that turn into errors).

tests/CMakeLists.txt Outdated Show resolved Hide resolved
@henryiii henryiii marked this pull request as ready for review May 16, 2022 21:26
@henryiii henryiii merged commit 1a7b129 into pybind:master May 16, 2022
@henryiii henryiii deleted the henryiii/fix/cuda branch May 16, 2022 21:27
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label May 16, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants