Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds set_name method of pybind11::capsule class #3866

Merged
merged 12 commits into from
Apr 14, 2022
Merged

Adds set_name method of pybind11::capsule class #3866

merged 12 commits into from
Apr 14, 2022

Commits on Apr 13, 2022

  1. Adds set_name method of pybind11::capsule class 

    This calls PyCapsule_SetName on the underlying capsule object.

modified destructors to query capsules's Name

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Handle possible exception thrown by PyCapsule_GetName

Also removed accidentally reintroduced use of `const char *&`.

[pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Fixed function name
    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    e2cd581 View commit details
    Browse the repository at this point in the history

  2. Introduced private static function to reuse get_name_or_throw

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    a39171c View commit details
    Browse the repository at this point in the history

  3. added tests for capsule renaming

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    d34d8c1 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    c895bc7 View commit details
    Browse the repository at this point in the history

  5. handle python error in flight

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    8e37191 View commit details
    Browse the repository at this point in the history

  6. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    99724a5 View commit details
    Browse the repository at this point in the history

  7. Initialized PyObject * variables to nullptr

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    0139f2b View commit details
    Browse the repository at this point in the history

  8. use write-unraisable if PyCapsule_GetName raises

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    563bcc9 View commit details
    Browse the repository at this point in the history

  9. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    46eccb8 View commit details
    Browse the repository at this point in the history

  10. get_name_or_throw->get_name_no_throw 

    If PyCapsule_GetName raises an error we should write as unraisable
to consume it and notify user, and then restore the error in flight if any.
This way this method called from destructor would not modify interpreter
error state.
    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    20df0d3 View commit details
    Browse the repository at this point in the history

  11. used error_scope struct

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 13, 2022
    Configuration menu
    Copy the full SHA
    0874dfd View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2022

  1. Renamed get_name_no_throw->get_name_in_error_scope

    @oleksandr-pavlyk
    oleksandr-pavlyk committed Apr 14, 2022
    Configuration menu
    Copy the full SHA
    4ed2c28 View commit details
    Browse the repository at this point in the history