fix: add missing moves in eval.h #3775
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skylion007
changed the title
Skylion007
changed the title
henryiii
approved these changes
Mar 2, 2022
henryiii
pushed a commit
to henryiii/pybind11
that referenced
this pull request
Mar 2, 2022
henryiii
pushed a commit
that referenced
this pull request
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was reading through the source code and noticed a couple of useful std::move were missing in eval.h. Seems clang-tidy didn't have the confidence to suggest them since they were in template functions. Now the behavior just matches the non-template version of the same function.