Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: use 'build' in tests instead of running setup.py #3734

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

henryiii
Copy link
Collaborator

@henryiii henryiii commented Feb 14, 2022

Description

Use build instead of direct setup.py commands in our tests. Mostly by @abravalheri, pulled from #3711.

Suggested changelog entry:

* Avoid ``setup.py <command>`` usage in internal tests.

Co-authored-by: Anderson Bravalheri <andersonbravalheri@gmail.com>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of my wheelhouse but LGTM.
Would be nice to add a sentence or two to the PR description, for build muggles like myself:

  • Was it the Python 2 or 3.5 drop that made this possible?
  • Why are we keeping setup.py? (Needed externally?)

@henryiii
Copy link
Collaborator Author

setup.py <command> is very deprecated. We shouldn't be using or promoting it. Using build is the correct alternative. This still runs setuptools, which still uses setup.py internally, but the use of commands is an implementation detail. We still heavily (for now) use setup.py. That might change in the future, though. :)

No, don't think it was the Python drop, it was just... Not sure why I used raw setup.py commands before, probably didn't realize the proper way to do it. Though the drop does make it easier to just add a specific build version.

@henryiii henryiii changed the title fix: use 'build' in tests instead of running setup.py tests: use 'build' in tests instead of running setup.py Feb 14, 2022
@henryiii henryiii merged commit a25d40c into pybind:master Feb 15, 2022
@henryiii henryiii deleted the henryiiii/fix/build branch February 15, 2022 05:32
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 15, 2022
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants