Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping MSVC 2015 #3722

Merged
merged 17 commits into from
Feb 14, 2022
Merged

Dropping MSVC 2015 #3722

merged 17 commits into from
Feb 14, 2022

Commits on Feb 14, 2022

  1. Changing _MSC_VER guard to < 1910 (dropping MSVC 2015).

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    0321897 View commit details
    Browse the repository at this point in the history

  2. Removing MSVC 2015 from ci.yml, and .appveyor.yml entirely.

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    a0d14ea View commit details
    Browse the repository at this point in the history

  3. Bringing back .appveyor.yml from master.

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    8c14771 View commit details
    Browse the repository at this point in the history

  4. appveyor Visual Studio 2017

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    8423316 View commit details
    Browse the repository at this point in the history

  5. 1st manual pass, builds & tests with unix_clang, before pre-commit.

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    7a09e61 View commit details
    Browse the repository at this point in the history

  6. After clang-format (via pre-commit).

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    dcf2ded View commit details
    Browse the repository at this point in the history

  7. Manual pass looking for "2015", builds & tests with unix_clang, befor… 

    …e pre-commit.
    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    637b27f View commit details
    Browse the repository at this point in the history

  8. Backtracking for include/pybind11 changes in previous commit. 

    git checkout d078658 include/pybind11/attr.h include/pybind11/detail/common.h include/pybind11/functional.h

--------------------

CI pybind#4160 errors observed:

pybind@2a26873
https://github.com/pybind/pybind11/runs/5168332130?check_suite_focus=true

$ grep ' error C' *.txt | sed 's/2022-02-12[^ ]*//' | sed 's/^[0-9][0-9]*//' | sed 's/^.*\.txt: //' | sort | uniqD:\a\pybind11\pybind11\include\pybind11\cast.h(1364,1): error C2752: 'pybind11::detail::type_caster<Eigen::Ref<Eigen::Vector3f,0,pybind11::EigenDStride>,void>': more than one partial specialization matches the template argument list [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]

d:\a\pybind11\pybind11\include\pybind11\detail/common.h(1023): error C2737: 'pybind11::overload_cast': 'constexpr' object must be initialized [D:\a\pybind11\pybind11\build\tests\cross_module_gil_utils.vcxproj]
d:\a\pybind11\pybind11\include\pybind11\detail/common.h(1023): error C2737: 'pybind11::overload_cast': 'constexpr' object must be initialized [D:\a\pybind11\pybind11\build\tests\pybind11_cross_module_tests.vcxproj]
d:\a\pybind11\pybind11\include\pybind11\detail/common.h(1023): error C2737: 'pybind11::overload_cast': 'constexpr' object must be initialized [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]
d:\a\pybind11\pybind11\include\pybind11\detail/common.h(1023): error C2737: 'pybind11::overload_cast': 'constexpr' object must be initialized [D:\a\pybind11\pybind11\build\tests\test_embed\external_module.vcxproj]
D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]
D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]

$ grep ': error C2737' *.txt | sed 's/^.*MSVC//' | sed 's/___.*//' | sort | uniq

_2017

$ grep ': error C2752' *.txt

3______3.8_____MSVC_2019_____x86_-DCMAKE_CXX_STANDARD=17.txt:2022-02-12T16:12:45.9921122Z D:\a\pybind11\pybind11\include\pybind11\cast.h(1364,1): error C2752: 'pybind11::detail::type_caster<Eigen::Ref<Eigen::Vector3f,0,pybind11::EigenDStride>,void>': more than one partial specialization matches the template argument list [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]

$ grep ': fatal error C1001:' *.txt

10______pypy-3.8-v7.3.7_____windows-2022_____x64.txt:2022-02-12T16:12:56.3163683Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
1______3.6_____MSVC_2019_____x86.txt:2022-02-12T16:12:47.6774625Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]
16______3.6_____windows-latest_____x64_-DPYBIND11_FINDPYTHON=ON.txt:2022-02-12T16:12:27.0556151Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
17______3.9_____windows-2019_____x64.txt:2022-02-12T16:12:30.3822566Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
2______3.7_____MSVC_2019_____x86.txt:2022-02-12T16:12:38.7018911Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\build\tests\pybind11_tests.vcxproj]
6______3.6_____windows-2022_____x64.txt:2022-02-12T16:12:00.4513642Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
7______3.9_____windows-2022_____x64.txt:2022-02-12T16:11:43.6306160Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
8______3.10_____windows-2022_____x64.txt:2022-02-12T16:11:49.9589644Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
9______pypy-3.7-v7.3.7_____windows-2022_____x64.txt:2022-02-12T16:11:53.7912112Z D:\a\pybind11\pybind11\include\pybind11\detail/common.h(624): fatal error C1001: Internal compiler error. [D:\a\pybind11\pybind11\tests\pybind11_tests.vcxproj]
    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    47cdcf0 View commit details
    Browse the repository at this point in the history

  9. common.h: is_template_base_of

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    8bd480a View commit details
    Browse the repository at this point in the history

  10. Re-applying 4 changes from 2a26873 that work universally.

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    e8334e2 View commit details
    Browse the repository at this point in the history

  11. overload_cast = {}; only for MSVC 2017 and Clang 5

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    f6480bd View commit details
    Browse the repository at this point in the history

  12. Refining condition for using is_template_base_of workaround.

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    baa474c View commit details
    Browse the repository at this point in the history

  13. Undoing MSVC 2015 workaround in test_constants_and_functions.cpp

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    4858b88 View commit details
    Browse the repository at this point in the history

  14. CentOS7: silence_unused_warnings

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    f072f4a View commit details
    Browse the repository at this point in the history

  15. Tweaks in response to reviews.

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    cff378c View commit details
    Browse the repository at this point in the history

  16. Adding windows-2022 C++20

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    ceac490 View commit details
    Browse the repository at this point in the history

  17. Trying another way of adding windows-2022 C++20

    Ralf W. Grosse-Kunstleve committed Feb 14, 2022
    Configuration menu
    Copy the full SHA
    cb0d114 View commit details
    Browse the repository at this point in the history