Adding ssize_t_cast to support passing size_t or ssize_t values where ssize_t is needed.
#3219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…A Format workflow.
rwgk
changed the title
ssize_t_cast to support passing size_t or ssize_t values where ssize_t is needed.
…lder compilers (to resolve link failures).
…e, for compatibility with older compilers (to resolve link failures).
|
The one macos failure is just a flake (the job never actually ran). |
Skylion007
approved these changes
Aug 28, 2021
|
Thanks @Skylion007 for the approval! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the problem described under PR #2692, but with a more general and more thorough implementation, including full unit test coverage for all functions with modified signatures.
The entire include/pybind11 directory was inspected for
static_cast<ssize_t>and(ssize_t)C-style casts. A couple tangential minor enhancements are included in this PR.clang-format-diff was applied.
Suggested changelog entry: