Avoid string copy if possible when passing a Python object to std::ostream #3042
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
operator<<(std::ostream &, const handle &)
to delegate tooperator<<(std::ostream &, std::string_view)
if possible. If I understand the type caster forstring_view
correctly, I think this avoids an unnecessary copy.The
PYBIND11_HAS_STRING_VIEW
macro is defined incast.h
, which is indirectly included bystl.h
. If that's likely to change in future, it might be desirable to move the macro tointernals.h
or something.Suggested changelog entry: