-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add pybind11::bytearray #2799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add pybind11::bytearray #2799
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
e9715aa
Add initial implementation
in42 f607da7
Add few more methods
in42 71cd50d
Add tests
in42 1bf3fd3
Fix a typo
in42 0472a64
Use std::string constructor which takes size
in42 2745cd9
Fix implicit sign conversion error
in42 95d348d
Add size method and test
in42 95ee903
Remove implicit conversion
in42 39756e2
Fix bytearray constructors and operator std::string()
in42 a0ea2d7
Make implicit bytearray constructor explicit
in42 4744d8e
Rerun tests
in42 2140f02
Add null check
in42 751a530
Rerun tests
in42 900ccdd
Rerun tests - 2
in42 f95c937
Remove NULL check
in42 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.