Skip to content

docs: add warning about FindPython's Development component when libraries don't exist (e.g. on manylinux) #2689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 24, 2020

Conversation

YannickJadoul
Copy link
Collaborator

Description

To reproduce, try building a project with FindPython on a random manylinux image.

See also https://gitlab.kitware.com/cmake/cmake/-/issues/20425 and pypa/manylinux#484.

Suggested changelog entry:

Just some docs, so not necessary.

@YannickJadoul YannickJadoul force-pushed the warning-findpython-no-libraries branch from 575ebf7 to 0039a77 Compare November 23, 2020 19:55
@henryiii henryiii changed the title Add waring about FindPython's Development component when libraries don't exist (e.g. on manylinux) docs: add warning about FindPython's Development component when libraries don't exist (e.g. on manylinux) Nov 24, 2020
@henryiii henryiii added the docs Docs or GitHub info label Nov 24, 2020
@henryiii henryiii merged commit 028812a into pybind:master Nov 24, 2020
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Nov 24, 2020
@YannickJadoul YannickJadoul deleted the warning-findpython-no-libraries branch November 26, 2020 21:42
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Docs or GitHub info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants